Skip to content

feat: setup subrouter for pub/sub trigger#704

Merged
anFatum merged 5 commits intogoogle:mainfrom
anFatum:pubsub-subrouter
Apr 8, 2026
Merged

feat: setup subrouter for pub/sub trigger#704
anFatum merged 5 commits intogoogle:mainfrom
anFatum:pubsub-subrouter

Conversation

@anFatum
Copy link
Copy Markdown
Contributor

@anFatum anFatum commented Apr 3, 2026

Create a new subrouter that will handle the pubsub trigger endpoint and add the implementation for this trigger.

This implementation should handle the resource exhausted exceptions with jitter to prevent thundering herd (configured per subrouter).

(see the details in go/orcas-rfc-522)

@anFatum anFatum force-pushed the pubsub-subrouter branch from 20af916 to 8df5c76 Compare April 3, 2026 12:36
@anFatum anFatum requested a review from kdroste-google April 3, 2026 12:40
Copy link
Copy Markdown
Collaborator

@kdroste-google kdroste-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

@anFatum anFatum force-pushed the pubsub-subrouter branch 6 times, most recently from b8ac13a to bba95b8 Compare April 7, 2026 13:47
@anFatum anFatum requested a review from kdroste-google April 8, 2026 08:00
@anFatum anFatum force-pushed the pubsub-subrouter branch from 566d495 to a60e758 Compare April 8, 2026 08:14
Copy link
Copy Markdown
Collaborator

@kdroste-google kdroste-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anFatum anFatum merged commit 0ad77f7 into google:main Apr 8, 2026
4 checks passed
hanorik pushed a commit to hanorik/adk-go that referenced this pull request Apr 8, 2026
Create a new subrouter that will handle the pubsub trigger endpoint and add the implementation for this trigger.
kdroste-google pushed a commit to kdroste-google/adk-go that referenced this pull request Apr 8, 2026
Create a new subrouter that will handle the pubsub trigger endpoint and add the implementation for this trigger.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants